search

magento / inventory

Magento Inventory Project (a.k.a MSI)
Open Software License 3.0
337 stars 248 forks source link

1.2.3 version is badly packaged in composer #3359

Open giacmir opened 2 years ago

giacmir commented 2 years ago

Summary (*)

After upgrading to Magento 2.4.5 my composer.lock indicates that I have installed version 1.2.3 of module-inventory-configurable-product

image

On github, looking at files for 1.2.3 tag, module directory /Plugin/CatalogInventory/ looks like this:

image

in my vendor directory the same directory looks like this:

image

As you can see what we have on github and what we have in the composer patches differs significantly (also... that file that is in the package but not on github has also a bug, and that's why I've discovered this misalignment).

Packaging automations (is exist) should ensure that the code that is packaged in composer is the same that we have on github at all times. Otherwise it will be impossible both to fix things and to be confident that what has been developed is the same product that will be shipped to the public.

m2-assistant[bot] commented 2 years ago

Hi @giacmir. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this