search

magento / m2-devtools

Helpful in-browser debugging/inspection tools for the Magento 2 Front-End
Open Software License 3.0
172 stars 48 forks source link

Backward compatibility and PHP cleanup #39

Closed Vinai closed 5 years ago

Vinai commented 5 years ago

This PR is a:

Summary

When this pull request is merged, it will make the module backward compatible with Magento 2.1 and 2.2 by supplying a setup_version in the etc/module.xml file.

Besides this it mainly removes unused imports, adds undeclared fields and adds imports and nicer aliases for classes that where used with the fully qualified class name.

Finally it also removes an interface violation where the method getFullActionName() was called on the interface \Magento\Framework\App\RequestInterface when it only exists on the implementation \Magento\Framework\App\Request\Http.

Related Issue #7

DrewML commented 5 years ago

Thanks @Vinai for making the first non-me contribution to this repo! And appreciate you hiding away all the warts in my copypasta