search

magento / m2-devtools

Helpful in-browser debugging/inspection tools for the Magento 2 Front-End
Open Software License 3.0
170 stars 48 forks source link

Force white background for dark themes #41

Closed gil-- closed 5 years ago

gil-- commented 5 years ago

This PR is a:

Summary

When this pull request is merged, it will allow Chrome dark themes to still use the UI.

Additional information

The extension has no global background-color which means when using Chrome's dark theme in devtools, the extension is unreadable:

screen shot 2018-12-11 at 2 57 00 pm

This adds a white background so that it's still possible to read:

screen shot 2018-12-11 at 2 56 15 pm

magento-cicd2 commented 5 years ago

CLA assistant check
All committers have signed the CLA.

DrewML commented 5 years ago

Thanks @gil--! Just flip the bit on the CLA and I'll merge.

DrewML commented 5 years ago

Also, FWIW, that module inspector was a playground that is pretty useless in its current state 😂