#47: Disable minification of JS assest when BundleConfig module enabled

magento / m2-devtools

Helpful in-browser debugging/inspection tools for the Magento 2 Front-End

Open Software License 3.0

172 stars 48 forks source link

#47: Disable minification of JS assest when BundleConfig module enabled #48

Closed aligent-lturner closed 5 years ago

aligent-lturner commented 5 years ago

This PR is a:

[x] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[ ] Bugfix
[ ] Test for existing code
[ ] Documentation

Summary

When this pull request is merged, it will disable minification of JS assets in core Magento code. This is done as the RequireJS optimizer needs JS files to not be minified to work correctly. Minification of other assets will be processed as normal.

Additional information

Related issue #47

magento-cicd2 commented 5 years ago

All committers have signed the CLA.

DrewML commented 5 years ago

Thanks so much @aligent-lturner for your first contribution to the repo! If you can make the tweak suggested by @Vinai I'll gladly land this.

aligent-lturner commented 5 years ago

Suggested changes by @Vinai have been made to make the code more readable and compliant with PSR-2.

DrewML commented 5 years ago

Thank you so much!