MCLOUD-6732: Fix issue with app/etc/env.php on build phase and remove named volumes

magento / magento-cloud-docker

All Submissions you make to Magento Inc. (“Magento") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here: https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html

Open Software License 3.0

256 stars 192 forks source link

Description

Fixed 2 issues:

Having app/etc/env.php will result in the broken build phase since services are not available
Replaced named volumes with regular, to avoid issues on Linux and WSL2

Fixed Issues (if relevant)

Manual testing scenarios

Build PHP images locally

Test in Developer mode
Test in Production mode

Release notes

Fixed issue when app/etc/env.php was breaking build process if present.
Replaced named volume with regular volumes to avoid issues on Linux and WSL2

Associated documentation updates

Add link to Magento DevDocs PR or Issue, if needed.

Contribution checklist

[ ] Pull request has a meaningful description of its purpose
[ ] Pull request introduces user-facing changes and includes meaningful release notes and documentation
[ ] All commits are accompanied by meaningful commit messages

magento / magento-cloud-docker