search

magento / magento-cloud-docker

All Submissions you make to Magento Inc. (“Magento") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here: https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html
Open Software License 3.0
256 stars 192 forks source link

Add ioncube support for PHP7.4 #314

Closed mattskr closed 3 years ago

mattskr commented 3 years ago

Adds back in support for ioncube extension with PHP 7.4 images. Code is identical to what is used for PHP 7.3 so should be able to merge quickly.

Description

Adds back missing code which was excluded in the first builds of PHP 7.4 images.

magento-cloud-ft-jenkins-svc commented 3 years ago

Unit & Integration Test Results

:white_check_mark: All unit and integration tests have passed.

Unit Test Output

PHPUnit 8.5.15 by Sebastian Bergmann and contributors.

.....                                                               5 / 5 (100%)

Time: 249 ms, Memory: 12.00 MB

OK (5 tests, 16 assertions)

Generating code coverage report in Clover XML format ... done [588 ms]

Integration Test Output

PHPUnit 8.5.15 by Sebastian Bergmann and contributors.

.............                                                     13 / 13 (100%)

Time: 2.32 seconds, Memory: 30.00 MB

OK (13 tests, 13 assertions)

This comment was generated by Jenkins job magento-cloud-docker/unit build 12.

magento-cloud-ft-jenkins-svc commented 3 years ago

Static Analysis & Code Style Results

:white_check_mark: All static analysis and code style checks have passed.

PHP Codesniffer Output

............................................................ 60 / 89 (67%)
.............................                                89 / 89 (100%)

Time: 3.61 secs; Memory: 10MB

PHP Mess Detector Output


Found 0 violations and 0 errors in 1802ms

No mess detected

PHPStan Output


 [OK] No errors

This comment was generated by Jenkins job magento-cloud-docker/static build 13.

magento-cloud-ft-jenkins-svc commented 3 years ago

Functional Acceptance Test Results

:x:  One or more functional acceptance tests have failed.

PHP 7.2

PHP 7.3

PHP 7.4

Output for failed tests is below. If many tests have failed only the first 5 will be included. If you need additional information please reach out to the Magento Cloud team for more details.

This comment was generated by Jenkins job magento-cloud-docker/functional build 15.

magento-cloud-ft-jenkins-svc commented 3 years ago

PHP 7.4 SplitDbCest Output

Codeception PHP Testing Framework v4.1.19
Powered by PHPUnit 8.5.15 by Sebastian Bergmann and contributors.

Acceptance Tests (1) ---------------------------------------
SplitDbCest: Test split db on production mode
Signature: Magento\CloudDocker\Test\Functional\Acceptance\SplitDbCest:testSplitDbOnProductionMode
Test: src/Test/Functional/Acceptance/SplitDbCest.php:testSplitDbOnProductionMode
Scenario --
 I cleanup work dir 
 I is cache work dir exists "master"
 I clone template to work dir "master"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "docker","1.2.99"
 I add artifacts repo to composer 
 I add dependency to composer "magento/magento-...","1.2.99"
 I add ece tools git repo to composer 
 I add dependency to composer "magento/e...","dev-devel..."
 I composer update 
 I assert true true,"Composer update failed"
 I cache work dir "master"
sh: rsync: not found
 I read services yaml 
 I read app magento yaml 
 I write services yaml {"mysql":{"type":"mysql:10.3","di...}
 I write app magento yaml {"name":"mymagento","type":"ph...}
 I write env magento yaml {"stage":{"global":{"SCD_ON_DE...}
 I get exposed port 
 I get exposed port "db_quote"
 I get exposed port "db_sales"
 I generate docker compose "--mode=production --expose-d..."
 I replace images with custom 
 I start environment 
 I run docker compose command "run build cloud-build"
 I run docker compose command "run deploy cloud-deploy"
 I am connected to database "db_quote"
 I grab num records "quote_id_mask"
 I stop environment 
 I remove work dir 
 ERROR 

------------------------------------------------------------
13x DEPRECATION: Passing a command as string when creating a "Symfony\Component\Process\Process" instance is deprecated since Symfony 4.2, pass it as an array of its arguments instead, or use the "Process::fromShellCommandline()" constructor if you need features provided by the shell. /app/vendor/symfony/process/Process.php:147
4x DEPRECATION: The Robo\Common\ProcessUtils::escapeArgument() method is a copy of a method that was deprecated by Symfony 3.3 and removed in Symfony 4; it will be removed in Robo 2.0. /app/vendor/consolidation/robo/src/Common/ProcessUtils.php:39

Time: 14.56 minutes, Memory: 16.00 MB

There was 1 error:

---------
1) SplitDbCest: Test split db on production mode
 Test  src/Test/Functional/Acceptance/SplitDbCest.php:testSplitDbOnProductionMode

  [PDOException] SQLSTATE[42S02]: Base table or view not found: 1146 Table 'magento2.quote_id_mask' doesn't exist  

Scenario Steps:

 30. $I->removeWorkDir() at src/Test/Functional/Acceptance/AbstractCest.php:53
 29. $I->stopEnvironment() at src/Test/Functional/Acceptance/AbstractCest.php:52
 28. $I->grabNumRecords("quote_id_mask") at src/Test/Functional/Acceptance/SplitDbCest.php:72
 27. $I->amConnectedToDatabase("db_quote") at src/Test/Functional/Acceptance/SplitDbCest.php:70
 26. $I->runDockerComposeCommand("run deploy cloud-deploy") at src/Test/Functional/Acceptance/SplitDbCest.php:68
 25. $I->runDockerComposeCommand("run build cloud-build") at src/Test/Functional/Acceptance/SplitDbCest.php:67

#1  Codeception\Module\Db->grabNumRecords
#2  /app/tests/functional/_support/_generated/CliTesterActions.php:1228
#3  /app/src/Test/Functional/Acceptance/SplitDbCest.php:72
#4  Magento\CloudDocker\Test\Functional\Acceptance\SplitDbCest->testSplitDbOnProductionMode

ERRORS!
Tests: 1, Assertions: 1, Errors: 1.
- XML report generated in file:///app/tests/functional/_output/junit.xml

This comment was generated by Jenkins job magento-cloud-docker/functional build 15.

shiftedreality commented 3 years ago

@mattskr could you please regenerate all PHP images?

shiftedreality commented 3 years ago

@magento import pr to magento-commerce/magento-cloud-docker

magento-engcom-team commented 3 years ago

@shiftedreality the pull request successfully imported.