magento / magento-cloud-docker

All Submissions you make to Magento Inc. (“Magento") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here: https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html
Open Software License 3.0
250 stars 188 forks source link

Docker image 2.3.6-p1 error affecting marketplace module testig #315

Open maurisource opened 3 years ago

maurisource commented 3 years ago

- Summary of the issue

Module submission on the Marketplace. There seems to be an error with that specific image.

- Information on your environment,

This environment is failing:

php_version":"7.3","magento_platform":"M2","magento_edition":"ce","magento_version":"2.3.6-p1","tool":"varnish","vendor":"maurisource","extension":"lightspeed","version":"1.3.62","platform":"m2","magento_cloud_docker":"1.2.1"

- Steps to reproduce

If you check submission ID: 0p8jeuucuj you'll be able to cross-check the error.

- Expected and actual results,

Actual relevant error as seen in the report.json file generated, which is irrelevant to the module.

Researching the error, I've found this possible solution: The issue is because during the install process Magento installs the store data, but then doesn't flush its cache.

n \u001b[37;41m Unable to apply patch Magento\\InventorySales\\Setup\\Patch\\Schema\\I \n nitializeW \u001b[39;49m \n \u001b[37;41m ebsiteDefaultSock for module Magento_InventorySales. Original exc \n eption mes \u001b[39;49m \n \u001b[37;41m sage: The default website isn't defined. Set the website and try \n again. \u001b[39;49m \n \u001b[37;41m

sloanfardele commented 3 years ago

Got the same issue here !

With environnement {"php_version":"7.3","magento_platform":"M2","magento_edition":"ce","magento_version":"2.3.6-p1","tool":"varnish","vendor":"laposte","extension":"magento2-colissimo-module","version":"1.1.0","platform":"m2","magento_cloud_docker":"1.2.1" and "php_version":"7.4","magento_platform":"M2","magento_edition":"ce","magento_version":"2.4.2","tool":"varnish","vendor":"laposte","extension":"magento2-colissimo-module","version":"1.1.0","platform":"m2","magento_cloud_docker":"1.2.1"

My submission ID is : rr7l1swgkx

shiftedreality commented 3 years ago

Hello @maurisource,

Could you provide steps to reproduce? Unfortunately, we do not have an access to submissions

maurisource commented 3 years ago

Hello @shiftedreality

In terms of reproducing the error, I think it depends on the module being submitted to the Marketplace. For now, as @sloanfardele also is complaining. Module maurisource/lightspeed and laposte/magento2-colissimo-module are being affected

Actions I have performed: Selected those Magento versions for CE (2.3 and 2.4) As you can see, the CE Docker image pertaining those Magento Screen Shot 2021-04-12 at 15 04 44 versions are both failing the technical submission with exit code 1.

"magento_edition":"ce","magento_version":"2.3.6-p1"
"magento_edition":"ce","magento_version":"2.4.2"

on EE, there's no errors at all pertaining Magento version 2.3 and 2.4

I have attached the report.json file and the screenshot of the Installation & Varnish install.

report-11.json.zip

sloanfardele commented 3 years ago

report.zip

Here is the report.json for laposte/magento2-colissimo-module. Our extension is not compatible with Magento EE, so I can only tell that I got the same errors on Magento CE

shiftedreality commented 3 years ago

Assigning to @slitviachenko for investigation

slitviachenko commented 3 years ago

@maurisource , @sloanfardele , as I mentioned in https://magentocommeng.slack.com/archives/C7SL5CGDN/p1617935586035800 , I was able to narrow down the root cause, both rr7l1swgkx and 0p8jeuucuj have cli commands, after disabling LaPoste\Colissimo\Console\Command\PurgeOldReturnLabels and LaPoste\Colissimo\Console\Command\PurgeLabelFolder, and Maurisource\Lightspeed\Console\Command\LsSyncAll respectively, I was able to install laposte/magento2-colissimo-module:1.1.0 and maurisource/lightspeed:1.3.62 on Magento 2.4.2 CE on Magento Cloud Docker 1.2.1.

slitviachenko commented 3 years ago

^^^ I believe Magento proxies could help to resolve this issue. https://devdocs.magento.com/guides/v2.4/extension-dev-guide/proxies.html

slitviachenko commented 3 years ago

@shiftedreality , below are some details:

docker-compose -f docker-compose.yml run --rm deploy cloud-deploy

command. The previous

docker-compose -f docker-compose.yml run --rm build cloud-build

command finishes successfully.

shiftedreality commented 3 years ago

Thank you for reporting this,

Internal issue: MCLOUD-7964