search

magento / magento-cloud-docker

All Submissions you make to Magento Inc. (“Magento") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here: https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html
Open Software License 3.0
256 stars 192 forks source link

Add docker-compose.yml to the release assets #325

Open tomaszmichalak opened 3 years ago

tomaszmichalak commented 3 years ago

Preconditions

Without Commerce Cloud license, Magento Community Edition users are not able to easily configure their local instances with Docker. The docker-compose.yml file can be generated using ece-docker which is not available for the open-source community.

Proposed solution

  1. Images are built and published to https://hub.docker.com/u/magento
  2. docker-compose.yml is added as an asset in https://github.com/magento/magento-cloud-docker/releases

Expected result

  1. docker-compose.yml is added as an asset in https://github.com/magento/magento-cloud-docker/releases

Actual result

  1. No docker-compose.yml for the open-source community.
shiftedreality commented 3 years ago

Hello @tomaszmichalak

The standalone docker-compose.yaml is not sufficient without the .docker directory that is created during compsoer update. Do you think it makes sense to attach it as is?

tomaszmichalak commented 3 years ago

@shiftedreality What is the purpose of the .docker directory? docker-compose.yml is extremely useful for development purposes as we "refresh" the stack almost every day.