search

magento / magento-cloud-docker

All Submissions you make to Magento Inc. (“Magento") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here: https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html
Open Software License 3.0
256 stars 192 forks source link

current php images fail to build because remote script change #331

Closed keithbentrup closed 2 years ago

keithbentrup commented 3 years ago

Steps to reproduce

  1. Try to build any php image that references https://deb.nodesource.com/setup_10.x. That includes the current dev branch and the latest tagged version (1.2.4).
  2. Since the current setup_10.x fails to properly install npm, npm install -g grunt-cli will fail and the build will not complete.

Expected result

  1. Successfully built php images.

Actual result

  1. npm not found and image build stops 
    Step 18/45 : RUN npm install -g grunt-cli
---> Running in 1b1a0bfaa66c
/bin/sh: 1: npm: not found

changing https://deb.nodesource.com/setup_10.x to https://deb.nodesource.com/setup_12.x will work, but I don't know what might require node v10.x.

YPyltiai commented 3 years ago

@BaDos , please see this issue.

andriyShevtsov commented 3 years ago

Created task ACMP-1539

BaDos commented 3 years ago

@keithbentrup it's fixed in 1.3.0

YPyltiai commented 2 years ago

@keithbentrup , could you please confirm the issue is resolved for you?