magento / magento-cloud-docker

All Submissions you make to Magento Inc. (“Magento") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here: https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html

Open Software License 3.0

256 stars 192 forks source link

Now it accepts also "n.n.n" form version number. #333

Closed greenflute closed 2 years ago

greenflute commented 3 years ago

Description

fixed error which init-docker.sh won't accept n.n.n form image version number.

Manual testing scenarios

init-docker.sh -p 7.4 -i 1.3.0 -> success
init-docker.sh -p 7.2 -i 1.1 -> success

Contribution checklist

[ ] Pull request has a meaningful description of its purpose
[ ] Pull request introduces user-facing changes and includes meaningful release notes and documentation
[ ] All commits are accompanied by meaningful commit messages

magento-cloud-ft-jenkins-svc commented 3 years ago

Static Analysis & Code Style Results

:white_check_mark: All static analysis and code style checks have passed.

PHP Codesniffer Output

............................................................ 60 / 89 (67%)
.............................                                89 / 89 (100%)

Time: 3.06 secs; Memory: 12MB

PHP Mess Detector Output


Found 0 violations and 0 errors in 1633ms

[32mNo mess detected[0m

PHPStan Output


 [OK] No errors

This comment was generated by Jenkins job magento-cloud-docker/static build 65.

magento-cloud-ft-jenkins-svc commented 3 years ago

Unit & Integration Test Results

:white_check_mark: All unit and integration tests have passed.

Unit Test Output

PHPUnit 8.5.21 by Sebastian Bergmann and contributors.

......                                                              6 / 6 (100%)

Time: 294 ms, Memory: 12.00 MB

OK (6 tests, 18 assertions)

Generating code coverage report in Clover XML format ... done [681 ms]

Integration Test Output

PHPUnit 8.5.21 by Sebastian Bergmann and contributors.

..................                                                18 / 18 (100%)

Time: 3.73 seconds, Memory: 36.00 MB

OK (18 tests, 18 assertions)

This comment was generated by Jenkins job magento-cloud-docker/unit build 64.

magento-cloud-ft-jenkins-svc commented 3 years ago

Functional Acceptance Test Results

:white_check_mark: All functional acceptance tests have passed.

PHP 7.2

:white_check_mark: Elasticsearch72Cest
:white_check_mark: Services72Cest
:white_check_mark: Acceptance72Cest

PHP 7.3

:white_check_mark: Elasticsearch73Cest
:white_check_mark: ServicesCest
:white_check_mark: Acceptance73Cest

PHP 7.4

:white_check_mark: ElasticsearchCest
:white_check_mark: DeveloperCest
:white_check_mark: MailHogCest
:white_check_mark: AcceptanceCest

This comment was generated by Jenkins job magento-cloud-docker/functional build 90.

magento-cloud-ft-jenkins-svc commented 3 years ago

Unit & Integration Test Results

:white_check_mark: All unit and integration tests have passed.

Unit Test Output

PHPUnit 8.5.21 by Sebastian Bergmann and contributors.

......                                                              6 / 6 (100%)

Time: 334 ms, Memory: 12.00 MB

OK (6 tests, 18 assertions)

Generating code coverage report in Clover XML format ... done [852 ms]

Integration Test Output

PHPUnit 8.5.21 by Sebastian Bergmann and contributors.

..................                                                18 / 18 (100%)

Time: 4.75 seconds, Memory: 36.00 MB

OK (18 tests, 18 assertions)

This comment was generated by Jenkins job magento-cloud-docker/unit build 66.

magento-cloud-ft-jenkins-svc commented 3 years ago

Static Analysis & Code Style Results

:white_check_mark: All static analysis and code style checks have passed.

PHP Codesniffer Output

............................................................ 60 / 89 (67%)
.............................                                89 / 89 (100%)

Time: 5.35 secs; Memory: 12MB

PHP Mess Detector Output


Found 0 violations and 0 errors in 1742ms

[32mNo mess detected[0m

PHPStan Output


 [OK] No errors

This comment was generated by Jenkins job magento-cloud-docker/static build 67.

magento-cloud-ft-jenkins-svc commented 3 years ago

Functional Acceptance Test Results

:white_check_mark: All functional acceptance tests have passed.

PHP 7.2

:white_check_mark: Elasticsearch72Cest
:white_check_mark: Services72Cest
:white_check_mark: Acceptance72Cest

PHP 7.3

:white_check_mark: Elasticsearch73Cest
:white_check_mark: ServicesCest
:white_check_mark: Acceptance73Cest

PHP 7.4

:white_check_mark: DeveloperCest
:white_check_mark: ElasticsearchCest
:white_check_mark: MailHogCest
:white_check_mark: AcceptanceCest

This comment was generated by Jenkins job magento-cloud-docker/functional build 92.

BaDos commented 2 years ago

Hi @greenflute It was fixed in the latest MCD release.