search

magento / magento-cloud-docker

All Submissions you make to Magento Inc. (“Magento") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here: https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html
Open Software License 3.0
256 stars 192 forks source link

mailhog service not generated in docker-compose.yml #339

Open andreidragutu opened 2 years ago

andreidragutu commented 2 years ago

Preconditions

  1. Docker Desktop 4.3.2, Engine 20.10.11, Compose 1.29.2 on macOS Monterey Apple Silicon (M1) - but not limited to this environment
  2. Magento Commerce 2.4.3-p1, php 7.4, MariaDB 10.4

Steps to reproduce

  1. Run: $ ./vendor/bin/ece-docker build:compose --mode="developer" --sync-engine="mutagen" --with-cron --mailhog-smtp-port=1025 --mailhog-http-port=8025 OR simply run: $ ./vendor/bin/ece-docker build:compose --mailhog-smtp-port=1025 --mailhog-http-port=8025
  2. Success message: Configuration was built.
  3. mailhog service is missing in docker-compose.yml but the header of docker-compose.yml is: 
    # ./vendor/bin/ece-docker 'build:compose' --mode=developer --sync-engine=mutagen --with-cron --mailhog-smtp-port=1025 --mailhog-http-port=8025
version: '2.1'

Expected result

services:
  mailhog:
    hostname: mailhog.magento2.docker
    image: 'mailhog/mailhog:latest'
    ports:
      - '1025:1025'
      - '8025:8025'
    networks:
      magento:
        aliases:
          - mailhog.magento2.docker

Actual result

mailhog service is missing from docker-compose.yml. We have to manually add it in docker-compose.override.yml.