search

magento / magento-cloud-docker

All Submissions you make to Magento Inc. (“Magento") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here: https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html
Open Software License 3.0
256 stars 192 forks source link

Latest releases no longer include init-docker.sh as asset #356

Closed MagicLegend closed 1 year ago

MagicLegend commented 1 year ago

Steps to reproduce

  1. Follow the documentation at https://developer.adobe.com/commerce/cloud-tools/docker/setup/initialize-docker/
  2. Realise the curl command is outdated, and try to update the version to 1.3.4 (latest as of writing)
  3. Curl will fail

Expected result

  1. The latest release version of init-docker.sh should be ran

Actual result

  1. Curl fails
BaDos commented 1 year ago

@MagicLegend thank you for your contribution!

The internal task was created to fix it.

MagicLegend commented 1 year ago

Perhaps the documentation should just point to the latest version instead of a version as well? That might also prevent issues down the road where versions used in the docs are unsupported.

Regardless, the releases here on Github should include the init-docker.sh file as an asset (which was my intention with the issue). Thank you for the quick response!

BaDos commented 1 year ago

@MagicLegend I will check the documentation, thank you!

All releases were fixed: https://github.com/magento/magento-cloud-docker/releases/tag/1.3.4 https://github.com/magento/magento-cloud-docker/releases/tag/1.3.3 https://github.com/magento/magento-cloud-docker/releases/tag/1.3.1