search

magento / magento-cloud-docker

All Submissions you make to Magento Inc. (“Magento") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here: https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html
Open Software License 3.0
256 stars 192 forks source link

add imagick PHP extension back for PHP 8.x #363

Open dossy opened 10 months ago

dossy commented 10 months ago

Description

PHP 8.x Docker images are missing the imagick PHP extension. This PR brings them back.

Bonus: This PR also adds WebP support to PHP 7.4 and PHP 8.x's GD extension.

Fixed Issues (if relevant)

  1. magento/magento-cloud-docker#357: Incompatibility with Magento >= 2.4.0 (Imagick missing)

Fixes #357.

Manual testing scenarios

  1. php bin/ece-docker image:generate:php
  2. Add the context images to your docker-compose.override.yml's services like this: 
    services:
fpm:
build:
  context: ./vendor/magento/magento-cloud-docker/images/php/8.1-fpm
  dockerfile: Dockerfile
fpm_xdebug:
build:
  context: ./vendor/magento/magento-cloud-docker/images/php/8.1-fpm
  dockerfile: Dockerfile
generic:
build:
  context: ./vendor/magento/magento-cloud-docker/images/php/8.1-cli
  dockerfile: Dockerfile
build:
build:
  context: ./vendor/magento/magento-cloud-docker/images/php/8.1-cli
  dockerfile: Dockerfile
deploy:
build:
  context: ./vendor/magento/magento-cloud-docker/images/php/8.1-cli
  dockerfile: Dockerfile
  3. docker compose build fpm
  4. docker compose run --rm fpm php -i | awk '/imagick module/,/^$/'
  5. Look for imagick module => enabled in the output from step 4.
  6. docker compose run --rm fpm php -i | awk '/GD Support/,/^$/'
  7. Look for WebP Support => enabled in the output from step 6.

Release notes

Associated documentation updates

Add link to Magento DevDocs PR or Issue, if needed.

Contribution checklist

dossy commented 10 months ago

Closing and re-opening after signing CLA.

MaximGns commented 5 months ago

will this ever be merged? lol