search

magento / magento-cloud

Magento Cloud
Open Software License 3.0
206 stars 237 forks source link

Remove magento-cloud build command #538

Open joeshelton-wagento opened 1 year ago

joeshelton-wagento commented 1 year ago

magento-cloud build

This command has always been problematic due to people mistakenly thinking it was a necessary part of local setup. Running the command is quite detrimental to a local installation of a Magento Cloud project due to the symlinks and other changes. To this day, people continue to be roadblocked by it: https://magento.stackexchange.com/questions/364313/magento-cloud-local-installation-issues

Previously, the argument for keeping the command (which always did more harm than good, imho) was that the build process could be demonstrated or tested outside of a Cloud environment. Now that Magento Cloud Docker is available, magento-cloud build is a poor substitute for a better tool. It is vestigial and should be removed.

nrdevau commented 3 months ago

Funny, I was just about to open an issue for suggesting

Maybe a Redeploy with Build Menu item in the Dev console or a flag on the magento-cloud CLI would help, if others are also experiencing that.

https://magentocommeng.slack.com/archives/C8CBB6K9V/p1722658805655599?thread_ts=1722586021.711859&cid=C8CBB6K9V

Am I to understand that magento-cloud build is actually already a command that causes the current checked out environment to run the build phase?

It seems the current community solution is to have an arbitrary environment that triggers builds as needed.

I have no idea who to tag here, as it would be a crossover between the Magento Cloud CLI and also the Magento Cloud developer console potentially.

joeshelton-wagento commented 3 months ago

magento-cloud build acts on the local environment where it is run. Not a remote environment.

magento-cloud redeploy acts on a remote environment. But as you noted, sometimes the build phase is not included in the redeployment. You should open a new issue if your concern is remote environments.

nrdevau commented 3 months ago

So to keep this momentum in this one, we're wanting to remove the magento-cloud build which aliases magento-cloud local:build from what I understand.

@joeshelton-wagento Is it likely that everyone moving forward will know about the magento-cloud-docker project?

Personally, I only found out about it while reading this issue, so perhaps an alternate solution is to mark this command as deprecated, and have a reference to the cloud docker project? My two cents.