search

magento / magento-coding-standard

Magento Coding Standard
Open Software License 3.0
349 stars 153 forks source link

Is there any reason why function `parse_url` is Discouraged? #401

Open VladyslavSikailo opened 2 years ago

VladyslavSikailo commented 2 years ago

When I use parse_url() function - phpcs shows me the following error:

 39 | WARNING | The use of function parse_url() is discouraged

Is there any reason why I should not use this function? I don't see any.

Do I have any alternative functions to use? It was possible to use \Zend\Uri\Http but it's removed starting from Magento 2.4.1.

Can I somehow remove it from the Discouraged function list using a custom ruleset? Seems like I can't. Update: I have disabled it using the following sentence, but not sure whether it right way

    <rule ref="Magento2.Functions.DiscouragedFunction">
        <properties>
            <property name="forbiddenFunctions" type="array">
                <element key="!parse_url" value="null"/>
            </property>
        </properties>
    </rule>

See: https://github.com/magento/magento-coding-standard/blob/develop/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php#L103

m2-assistant[bot] commented 2 years ago

Hi @Dren7755. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this