Open fredden opened 2 years ago
Hi @fredden. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this
@fredden have a look at https://github.com/magento/magento-coding-standard/issues/156
@Nuranto thanks for your feedback.
I have no problem with the warning / message that says that helpers are deprecated / should not be used. I have no problem with the warning / message that says that one should use $block->getThing()
not $this->getThing()
in templates. I have no problem with the auto-fix of $this->getThing()
to $block->getThing()
.
This bug is for when $this->helper()
gets replaced automatically with $block->helper()
, which results in a broken template. (The automatic replacement of $this->getThing()
with $block->getThing()
is fine and the template works just fine with this change.)
I understand, and agree but my point was that they probably won’t do anything about it since they consider this is a not a correct approach.
For my projects, I simply run the fixer with that rule excluded. But of course that means it won’t fix other $this cases..
That's what we've had to do as well (remove/exclude this rule from the fixer).
Preconditions
.phtml
file), make use of$this->helper(SomeClass:class);
. For example, https://github.com/magento/magento2/blob/2.4.4/app/code/Magento/Catalog/view/frontend/templates/product/listing.phtml#L20Steps to reproduce
phpcbf --standard=Magento2
on templateExpected result
Actual result
Invalid method Vendor\Module\Block\SomeBlockClass\Interceptor::helper