False Positive: Magento2.Legacy.InstallUpgrade.ObsoleteInstallDataScript - Githubissues

magento / magento-coding-standard

Magento Coding Standard

Open Software License 3.0

347 stars 153 forks source link

False Positive: Magento2.Legacy.InstallUpgrade.ObsoleteInstallDataScript #411

Open dfelton opened 2 years ago

dfelton commented 2 years ago

Preconditions

Package contains data patch \VendorName\ModuleName\Setup\Patch\Data\InstallData (exact nature of data patch irrelevant)

Steps to reproduce

Run the coding standard against the file Setup/Patch/Data/InstallData.php

Expected result

Sniff Magento2.Legacy.InstallUpgrade.ObsoleteInstallDataScript to not be triggered by the presence of a data patch named InstallData, as it is not a Setup/InstallData.php script.

Actual result

Data patch fails due to Magento2.Legacy.InstallUpgrade.ObsoleteInstallDataScript sniff.

Misc Notes:

Possible to disable failure with phpcs:ignore Magento2.Legacy.InstallUpgrade.ObsoleteInstallDataScript annotation within the file. Line must be present on line 1, after the opening PHP tag.

m2-assistant[bot] commented 2 years ago

Hi @dfelton. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.