search

magento / magento-coding-standard

Magento Coding Standard
Open Software License 3.0
347 stars 153 forks source link

Ignore HTML comments #482

Open minsc78 opened 3 months ago

minsc78 commented 3 months ago

Preconditions

  1. Have a file test.html like this: 
    <!-- Comment <http://site.com/path/> -->

Steps to reproduce

  1. Run vendor/bin/phpcs -s --standard=Magento2 test.html

Expected result

  1. Show no errors.

Actual result

  1. Getting this output: 
    ------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
1 | ERROR | Avoid using self-closing tag with non-void html element - "<http://site.com/path/>
|       |  (Magento2.Html.HtmlSelfClosingTags.HtmlSelfClosingNonVoidTag)
------------------------------------------------------------------------------------------------
m2-assistant[bot] commented 3 months ago

Hi @minsc78. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information. Add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.