magento / magento-semver

Magento Semantic Versioning Checker. Join #svc in our Community Slack: https://opensource.magento.com/slack. Static tests that identify required module version changes based on code diff, and look for backward incompatible changes.

Other

32 stars 25 forks source link

Added code style checks #23

Closed slavvka closed 4 years ago

slavvka commented 4 years ago

Description (*)

Added code style checks
Fixed code style in code and tests

Contribution checklist (*)

[ ] Pull request has a meaningful description of its purpose
[ ] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds are green)

lenaorobei commented 4 years ago

I would say we need to use https://github.com/magento/magento-coding-standard, but if there was a specific requirement to use PSR12 - I'm ok with this.

slavvka commented 4 years ago

@lenaorobei There's no requirements to use PSR12. I just took it as the latest actual and by my own initiative. Is https://github.com/magento/magento-coding-standard applicable to non-Magento code? Because it is a standalone library which has nothing common with Magento

lenaorobei commented 4 years ago

@slavvka yes, there are some specific Magento checks but PSR2 is included. PRS12 is in progress right now, so probably you're right, if only code style is needed PSR12 is the best option.