False positive - Imported class with alias detected as MAJOR change

magento / magento-semver

Magento Semantic Versioning Checker. Join #svc in our Community Slack: https://opensource.magento.com/slack. Static tests that identify required module version changes based on code diff, and look for backward incompatible changes.

Other

32 stars 25 forks source link

False positive - Imported class with alias detected as MAJOR change #49

Closed ihor-sviziev closed 3 years ago

ihor-sviziev commented 4 years ago

As part of https://github.com/magento/magento2/pull/27129 we got SVC failure.

There was changed \Magento\Catalog\Model\Product\Link to LinkModel

because it was just imported at the top of the file:

use Magento\Catalog\Model\Product\Link as LinkModel;

And we got following report:

m2-assistant[bot] commented 4 years ago

Hi @ihor-sviziev. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

ihor-sviziev commented 3 years ago

Looks like it was fixed in https://github.com/magento/magento-semver/commit/916d4ded3e4c38258ab2457870e1161d38236a3a.