False positive - Method has been added

magento / magento-semver

Magento Semantic Versioning Checker. Join #svc in our Community Slack: https://opensource.magento.com/slack. Static tests that identify required module version changes based on code diff, and look for backward incompatible changes.

Other

32 stars 25 forks source link

False positive - Method has been added #50

Closed ihor-sviziev closed 3 years ago

ihor-sviziev commented 4 years ago

We found this issue as part of processing following PR: https://github.com/magento/magento2/pull/30001

When we adding some get parameter and constructor wasn't overridden yet for this class - we're having following failure:

m2-assistant[bot] commented 4 years ago

Hi @ihor-sviziev. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

ihor-sviziev commented 3 years ago

Fixed in https://github.com/magento/magento-semver/commit/e64773c1e73650beea69dda59cf1a66ea61b95ce