![Arrows] MC-36802: SVC doesn't catch MINOR change in PATCH release when adding @api to a class

magento / magento-semver

Magento Semantic Versioning Checker. Join #svc in our Community Slack: https://opensource.magento.com/slack. Static tests that identify required module version changes based on code diff, and look for backward incompatible changes.

Other

32 stars 25 forks source link

![Arrows] MC-36802: SVC doesn't catch MINOR change in PATCH release when adding @api to a class #55

Closed zakdma closed 3 years ago

zakdma commented 4 years ago

Scope

Bug - P1

MC-36802 SVC doesn't catch MINOR change in PATCH release when adding @api to a class

Created by : @zakdma

zakdma commented 4 years ago

@roribio @vkublytskyi please review this PR

vkublytskyi commented 4 years ago

@maghamed, please confirm that from an architectural point of view this is desired behavior:

@api annotation added - minor change
@api annotation removed - minor change

maghamed commented 4 years ago

Why do we consider that api annotation removal is Minor but not a Major change?

zakdma commented 4 years ago

@vkublytskyi @maghamed @api removal classification changed to major

okorshenko commented 3 years ago

@magento import pull request to https://github.com/magento-tsg/magento-semver

sidolov commented 3 years ago

@magento import pull request to https://github.com/magento-tsg/magento-semver

magento-engcom-team commented 3 years ago

@sidolov, an error occurred during the Pull Request import.

zakdma commented 3 years ago

Closed in favor of https://github.com/magento-commerce/magento-semver/pull/11