search

magento / magento-semver

Magento Semantic Versioning Checker. Join #svc in our Community Slack: https://opensource.magento.com/slack. Static tests that identify required module version changes based on code diff, and look for backward incompatible changes.
Other
32 stars 25 forks source link

Add compatiblity for constructor property promotions #70

Open leonhelmus opened 1 year ago

leonhelmus commented 1 year ago

Add the moment i'm busy with adding constructor promotion properties to Magento Open Source, see: https://github.com/magento/magento2/pull/37032 https://github.com/magento/magento2/pull/37037 https://github.com/magento/magento2/pull/37040 and 20 others.

But i'm having the following issue at the moment: See the code of this Pull Request: https://github.com/magento/magento2/pull/37038 image See the code of this Pull Request: https://github.com/magento/magento2/pull/37037 image

It looks like in some cases it does not recognize some of the property promotions that i've used.

To me it looks like it's not supported. Could someone help me resolve this issue?

m2-assistant[bot] commented 1 year ago

Hi @leonhelmus. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information. Add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.