magento / magento-semver

Magento Semantic Versioning Checker. Join #svc in our Community Slack: https://opensource.magento.com/slack. Static tests that identify required module version changes based on code diff, and look for backward incompatible changes.
Other
32 stars 25 forks source link

Detect when virtualTypes move elsewhere #72

Closed fredden closed 7 months ago

fredden commented 1 year ago

Description

While working on https://github.com/magento/magento2/pull/32690, it was noticed that a virtualType which is used in multiple modules (namely shellBackground used in both Magento_Cron and Magento_MessageQueue). Moving this to app/etc/di.xml where it belongs triggered an automated test failure from this tool. This pull request aims to handle this case as expected.

Manual testing scenarios

Unit tests are included with this change. Without the code change, these unit tests fail.

Contribution checklist

ihor-sviziev commented 1 year ago

@sidolov please merge this pull request

engcom-Charlie commented 7 months ago

@sidolov can you please merge this PR. https://github.com/magento/magento2/pull/32690 is depended on this PR.

sidolov commented 7 months ago

@magento import pr to magento-commerce/magento-semver repository

m2-github-services commented 7 months ago

@sidolov the Pull Request is successfully imported.