magento / magento2-functional-testing-framework

Magento2 Functional Testing Framework
Other
155 stars 133 forks source link

Update allure-codeception in order to support php8 #825

Closed ihor-sviziev closed 3 years ago

ihor-sviziev commented 3 years ago

Description

This PR updates allure-codeception to version 1.5 in order to bring compatibility with PHP8. It is needed in order to resolve dependencies issue for https://github.com/magento/magento2/pull/32614

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#: Issue title
  2. ...

Contribution checklist

ihor-sviziev commented 3 years ago

Looks like unit test failures not related to changes from this PR.

jilu1 commented 3 years ago

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

magento-engcom-team commented 3 years ago

@jilu1 the pull request successfully imported.

jilu1 commented 3 years ago

@ihor-sviziev since our build infrastructure is not currently support php8 and other php8 work is still WIP, we have created a new branch php8-develop and this PR is merged into that branch. Please let us know if this works for you.

ihor-sviziev commented 3 years ago

@jilu1 but somehow it's still not showing merged. Should I change target to that branch ?

jilu1 commented 3 years ago

@ihor-sviziev I think you are right. I just reverted your commit from php8-develop, after it's sync with public repo (you might want to wait a bit), you can change PR to base from php8-develop.

jilu1 commented 3 years ago

@ihor-sviziev you can fix the base of this PR now.

ihor-sviziev commented 3 years ago

@jilu1 changed target to php8-develop

jilu1 commented 3 years ago

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

magento-engcom-team commented 3 years ago

@jilu1 the pull request successfully imported.