Updated monolog/monolog to ^2.2

magento / magento2-functional-testing-framework

Magento2 Functional Testing Framework

Other

155 stars 133 forks source link

Updated monolog/monolog to ^2.2 #832

Closed drpayyne closed 3 years ago

drpayyne commented 3 years ago

Description

Updated monolog/monolog to ^2.2 as part of the "Platform Health" updates in the main repo.

Related Pull Requests

Fixed Issues

https://github.com/magento/magento2/issues/32868

Contribution checklist

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[x] All new or changed code is covered with unit/verification tests (if applicable)
[x] All automated tests passed successfully (all builds on Travis CI are green)
[x] Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

drpayyne commented 3 years ago

Hi @sivaschenko, I've fixed the failing tests, but the two PHPUnit checks are failing due to some resource error. I'm not sure how to fix it from my side. Could you please check on this? Thanks.

sivaschenko commented 3 years ago

@jilu1 can you please prioritize this pull request to include the changes in the earliest MFTF release, as it blocks the dependency update in the Magento core.

sivaschenko commented 3 years ago

@drpayyne is it possible to debug Unit tests by running https://github.com/magento/magento2-functional-testing-framework/blob/develop/bin/phpunit-checks locally to try to identify the root cause?

sivaschenko commented 3 years ago

@drpayyne actually I can see the same failure in another PR https://github.com/magento/magento2-functional-testing-framework/pull/830

So it might not be related to the changes in the pull request

@jilu1 is that a known issue?

drpayyne commented 3 years ago

Updated commits to use Compoer 2.0.14 to prevent unnecessary lock file changes.

jilu1 commented 3 years ago

@drpayyne Thank you for your PR!

You can ignore the Error: Resource not accessible by integration for now. This error only happens in this public repository and not in our mirror internal repository. We will investigate the issue soon.

jilu1 commented 3 years ago

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

magento-engcom-team commented 3 years ago

@jilu1 the pull request successfully imported.

jilu1 commented 3 years ago

@sivaschenko Is this monolog/monolog upgrade targeted for Magento 2.4-develop?

sivaschenko commented 3 years ago

@jilu1 Magento pull requests are updated with reference to the branch of this pull request for MFTF. Tests are running in https://github.com/magento/magento2/pull/33226