magento / magento2-functional-testing-framework

Magento2 Functional Testing Framework
Other
155 stars 133 forks source link

33292 replace AspectMock from BaseGenerateCommandTest #840

Closed SilinMykola closed 3 years ago

SilinMykola commented 3 years ago

Description

Eliminate AspectMock usage from dev/tests/unit/Magento/FunctionalTestFramework/Console/BaseGenerateCommandTest.php

Fixed Issues (if relevant)

  1. magento/magento2#33292: [MFTF] Replace AspectMock with PHPUnit for BaseGenerateCommandTest #33292

Contribution checklist

jilu1 commented 3 years ago

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

jilu1 commented 3 years ago

@SilinMykola Thank you for your pull request! We will review and update you soon.

jilu1 commented 3 years ago

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

sivaschenko commented 3 years ago

@SilinMykola thanks for the pull request! Would you be able to respond to the code review comments?

SilinMykola commented 3 years ago

@sivaschenko yes, I'll try to change code after review. I need some time for this.

bohdan-harniuk commented 3 years ago

Hello, @jilu1

I have a little bit helped for @SilinMykola with the aspect mock replacement here to match the original behaviour (+ with the implementation of what you asked for). Please, proceed with the code review.

cc: @SilinMykola, @sivaschenko

jilu1 commented 3 years ago

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

magento-engcom-team commented 3 years ago

@jilu1 the pull request successfully imported.

jilu1 commented 3 years ago

@bohdan-harniuk Great solution! Looks good to me. Thanks for your contribution!

bohdan-harniuk commented 3 years ago

Hello, @jilu1

This task was finished without creating new singletons, so it is not a blocker. We can go further here.

Thanks, Bohdan