Closed SilinMykola closed 3 years ago
@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework
@SilinMykola Thank you for your pull request! We will review and update you soon.
@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework
@SilinMykola thanks for the pull request! Would you be able to respond to the code review comments?
@sivaschenko yes, I'll try to change code after review. I need some time for this.
Hello, @jilu1
I have a little bit helped for @SilinMykola with the aspect mock replacement here to match the original behaviour (+ with the implementation of what you asked for). Please, proceed with the code review.
cc: @SilinMykola, @sivaschenko
@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework
@jilu1 the pull request successfully imported.
@bohdan-harniuk Great solution! Looks good to me. Thanks for your contribution!
Hello, @jilu1
This task was finished without creating new singletons, so it is not a blocker. We can go further here.
Thanks, Bohdan
Description
Eliminate AspectMock usage from
dev/tests/unit/Magento/FunctionalTestFramework/Console/BaseGenerateCommandTest.php
Fixed Issues (if relevant)
Contribution checklist