magento / magento2-functional-testing-framework

Magento2 Functional Testing Framework
Other
155 stars 133 forks source link

33295: Eliminate AspectMock from FileStorageTest #842

Closed karyna-tsymbal-atwix closed 3 years ago

karyna-tsymbal-atwix commented 3 years ago

Eliminated AspectMock usage from dev/tests/unit/Magento/FunctionalTestFramework/DataGenerator/Handlers/SecretStorage/FileStorageTest.php

note: in this case, main complexity is in a private functions calls rather than static

Fixed Issues (if relevant)

  1. Fixes magento/magento2#33295: [MFTF] Eliminate AspectMock from FileStorageTest (Complex!)

Contribution checklist

andrewbess commented 3 years ago

Hello @karyna-tsymbal-atwix Thank you for your PR. It looks well to me.

jilu1 commented 3 years ago

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

magento-engcom-team commented 3 years ago

@jilu1 the pull request successfully imported.

bohdan-harniuk commented 3 years ago

Hello, @jilu1

This task was finished without creating new singletons, so it is not a blocker.

Thanks, Bohdan