magento / magento2-functional-testing-framework

Magento2 Functional Testing Framework
Other
155 stars 133 forks source link

MFTF-33305: Eliminate AspectMock from ObjectExtensionUtilTest #843

Closed bohdan-harniuk closed 3 years ago

bohdan-harniuk commented 3 years ago

Description

Eliminated AspectMock usage in the \tests\unit\Magento\FunctionalTestFramework\Test\Util\ObjectExtensionUtilTest.

Fixed Issues (if relevant)

  1. magento/magento2#33305: [MFTF] Eliminate AspectMock from ObjectExtensionUtilTest (Complex!)

Additional information

As the main idea of this issue to eliminate AspectMock usage in the ObjectExtensionUtilTest class, AspectMock usage eliminated only partially in the MockModuleResolverBuilder. It is a required action because in that class the \Magento\FunctionalTestingFramework\Util\ModuleResolver mocked instance hardcoded to be retrieved by the ObjectManager mocked object on its create method without any argument.

Contribution checklist

bohdan-harniuk commented 3 years ago

Hello, @jilu1

In this task, we don't have any new singletons created. Please, proceed with the code review!

Thanks, Bohdan

jilu1 commented 3 years ago

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

magento-engcom-team commented 3 years ago

@jilu1 the pull request successfully imported.