MFTF-33302: Eliminated AspectMock from ActionGroupObjectTest - Githubissues

magento / magento2-functional-testing-framework

Magento2 Functional Testing Framework

Other

155 stars 133 forks source link

MFTF-33302: Eliminated AspectMock from ActionGroupObjectTest #846

Closed bohdan-harniuk closed 3 years ago

bohdan-harniuk commented 3 years ago

Description

Eliminated AspectMock usage from the \tests\unit\Magento\FunctionalTestFramework\Test\Objects\ActionGroupObjectTest

Fixed Issues (if relevant)

magento/magento2#33302: Eliminate AspectMock from ActionGroupObjectTest (Complex!)

Contribution checklist

[ ] Pull request has a meaningful description of its purpose
[ ] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/verification tests (if applicable)
[ ] All automated tests passed successfully (all builds on Travis CI are green)
[ ] Changes to Framework doesn't have backwards-incompatible changes for tests or have related Pull Request with fixes to tests

bohdan-harniuk commented 3 years ago

Hello, @jilu1

This task was finished without creating new singletons, so it is not a blocker. You can proceed with the code review.

Thanks, Bohdan