magento / magento2-functional-testing-framework

Magento2 Functional Testing Framework
Other
155 stars 133 forks source link

33297: Eliminate AspectMock from DataExtensionUtilTest #849

Closed karyna-tsymbal-atwix closed 3 years ago

karyna-tsymbal-atwix commented 3 years ago

Description

Eliminated AspectMock usage from dev/tests/unit/Magento/FunctionalTestFramework/DataGenerator/Util/DataExtensionUtilTest.php

In the scope of this ticket I also refactored dev/tests/unit/Magento/FunctionalTestFramework/DataGenerator/Persist/OperationDataArrayResolverTest.php

DataObjectHandler instance, mocked with AspectMock, is not cleaned in OperationDataArrayResolverTest, thus it broke DataExtensionUtilTest after my refactoring. As our main purpose to eliminate AspectMock completely, I decided to refactor OperationDataArrayResolverTest also.

Fixed Issues (if relevant)

  1. Fixes magento/magento2#33297: [MFTF] Eliminate AspectMock from DataExtensionUtilTest (Complex!)

Contribution checklist

jilu1 commented 3 years ago

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

magento-engcom-team commented 3 years ago

@jilu1 the pull request successfully imported.

jilu1 commented 3 years ago

@karyna-tsymbal-atwix Any reason you closed this PR?

karyna-tsymbal-atwix commented 3 years ago

Hi @jilu1 , there were some changes, a new PR is here: https://github.com/magento/magento2-functional-testing-framework/pull/856