search

magento / magento2-functional-testing-framework

Magento2 Functional Testing Framework
Other
155 stars 133 forks source link

33293: Eliminated AspectMock usage from PersistedObjectHandlerTest.php #853

Closed anzin closed 3 years ago

anzin commented 3 years ago

Description

I've eliminated AspectMock usage from dev/tests/unit/Magento/FunctionalTestFramework/DataGenerator/Handlers/PersistedObjectHandlerTest.php

Fixed Issues (if relevant)

  1. Fixes magento/magento2#33293:[MFTF] Replace AspectMock with PHPUnit for PersistedObjectHandlerTest

Contribution checklist

jilu1 commented 3 years ago

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

magento-engcom-team commented 3 years ago

@jilu1 the pull request successfully imported.

jilu1 commented 3 years ago

Closed by accident. reopen it :)

jilu1 commented 3 years ago

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

magento-engcom-team commented 3 years ago

@jilu1, an error occurred during the Pull Request import.

jilu1 commented 3 years ago

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

magento-engcom-team commented 3 years ago

@jilu1, an error occurred during the Pull Request import.

jilu1 commented 3 years ago

@anzin Is this PR ready for review?

anzin commented 3 years ago

Hello, @jilu1 Yes, you can review this PR. @bohdan-harniuk has found one mistake and asked me to fix that. Now everything should be fine.

jilu1 commented 3 years ago

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

magento-engcom-team commented 3 years ago

@jilu1, an error occurred during the Pull Request import.

jilu1 commented 3 years ago

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

magento-engcom-team commented 3 years ago

@jilu1 the pull request successfully imported.

jilu1 commented 3 years ago

@anzin Should you also update here https://github.com/magento/magento2-functional-testing-framework/pull/853/files#diff-16310c27840f10b029f0073735a9e114d59562a084c5e38a109eacdbf3a05f5cR265?

Nice solution!

bohdan-harniuk commented 3 years ago

@anzin Should you also update here https://github.com/magento/magento2-functional-testing-framework/pull/853/files#diff-16310c27840f10b029f0073735a9e114d59562a084c5e38a109eacdbf3a05f5cR265?

Nice solution!

Hello, @jilu1!

Your link leads to the same PR and with outdated changes (I cannot see what you wanted to show). Could you please check it and provide what do we need to change?

Thanks, Bohdan

jilu1 commented 3 years ago

@anzin Should you also update here https://github.com/magento/magento2-functional-testing-framework/pull/853/files#diff-16310c27840f10b029f0073735a9e114d59562a084c5e38a109eacdbf3a05f5cR265? Nice solution!

Hello, @jilu1!

Your link leads to the same PR and with outdated changes (I cannot see what you wanted to show). Could you please check it and provide what do we need to change?

Thanks, Bohdan

@bohdan-harniuk I mean it looks like a missed update in line #264~#265 in PersistedObjectHandlerTest.php.

bohdan-harniuk commented 3 years ago

@anzin Should you also update here https://github.com/magento/magento2-functional-testing-framework/pull/853/files#diff-16310c27840f10b029f0073735a9e114d59562a084c5e38a109eacdbf3a05f5cR265? Nice solution!

Hello, @jilu1! Your link leads to the same PR and with outdated changes (I cannot see what you wanted to show). Could you please check it and provide what do we need to change? Thanks, Bohdan

@bohdan-harniuk I mean it looks like a missed update in line #264~#265 in PersistedObjectHandlerTest.php.

Oh, I can see now!! Thank you, @jilu1! We will fix that!