magento / magento2-functional-testing-framework

Magento2 Functional Testing Framework
Other
155 stars 133 forks source link

33306: Eliminated AspectMock from the ParallelGroupSorterTest class #857

Closed bohdan-harniuk closed 3 years ago

bohdan-harniuk commented 3 years ago

Description

Eliminated usage of AspectMock from the \tests\unit\Magento\FunctionalTestFramework\Util\Sorter\ParallelGroupSorterTest.

Fixed Issues (if relevant)

  1. magento/magento2#33306: [MFTF] Replace AspectMock with PHPUnit for ParallelGroupSorterTest

Contribution checklist

bohdan-harniuk commented 3 years ago

Hello, @jilu1

This task was finished without creating new singletons, so it is not a blocker. You can proceed with the code review.

Thanks, Bohdan

okolesnyk commented 3 years ago

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

magento-engcom-team commented 3 years ago

@okolesnyk the pull request successfully imported.

jilu1 commented 3 years ago

Please update with the latest develop branch and re-run unit tests. Let us know if you can reproduce the error.

bohdan-harniuk commented 3 years ago

Hello, @jilu1!

I'll look at it, thank you!

bohdan-harniuk commented 3 years ago

Hello, @jilu1!

I've found and fixed that error after the branch actualisation. Please, proceed with the review.

Thanks, Bohdan