magento / magento2-functional-testing-framework

Magento2 Functional Testing Framework
Other
155 stars 133 forks source link

33582: Eliminated AspectMock from MagentoTestCase.php #863

Closed anzin closed 3 years ago

anzin commented 3 years ago

Description

I've eliminated AspectMock from \tests\unit\Util\MagentoTestCase.

This PR needs to be merged after all PRs with the eliminated AspectMock, will be merged.

Related Pull Requests

852

857

843

837

848

846

845

859

856

855

842

839

853

840

844

850

Fixed Issues (if relevant)

  1. Fixes magento/magento2#33582

Contribution checklist

okolesnyk commented 3 years ago

@anzin please take a look at my comment

anzin commented 3 years ago

Hello @okolesnyk, I've reverted the method fileExists(), please check if everything is well.

Thanks

okolesnyk commented 3 years ago

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

magento-engcom-team commented 3 years ago

@okolesnyk the pull request successfully imported.

bohdan-harniuk commented 3 years ago

@jilu1, all failed tests will be passed right after https://github.com/magento/magento2-functional-testing-framework/pull/861 and https://github.com/magento/magento2-functional-testing-framework/pull/865 would be merged.

Here is the result in the local env (two branches mentioned before were merged):

Screenshot 2021-08-11 at 18 14 50

So, let’s here wait for those PRs to be merged.

Thanks, Bohdan

jilu1 commented 3 years ago

@bohdan-harniuk All relevant PRs are merged. Please sync with develop and remove AspectMock from composer.json and update composer.lock.

Great Job on your team!

bohdan-harniuk commented 3 years ago

Thank you, @jilu1!

I'll proceed with the requested changes!

Thanks, Bohdan