MFTF-33780: Changed loose comparisons into strict

bohdan-harniuk commented 3 years ago

Description

In this PR loose comparison operators were changed to the strict comparison operators. These changes apply to the next comparison operators:

== changed to ===
!= changed to !==

Reason of those changes: With the PHP RFC updates often changes rules of loose comparison operators interpretation. So, for each MFTF codebase update to the new PHP version, if there is any update in the loose comparison operators interpretation, we must check every line of code where such operators are used to clarify if those changes applies to our codebase. A lot easier to replace loose operators with the strict ones to eliminate such problems in the future.

This PR doesn’t cover operations that perform non-strict comparisons with the next parts:

functions: in_array(), array_search() and array_keys() (without declaring strict types)
sorting functions: sort(), rsort(), asort(), arsort() and array_multisort() (with $sort_flags set to SORT_REGULAR, which is the default)

Those cases would be considered only if any build fails on them.

I've run all Magento 2 MFTF tests for the CE, EE, B2B repositories on the current branch:

All tests passed successfully:

https://github.com/magento/magento2/pull/33866

Fixed Issues (if relevant)

https://github.com/magento/magento2/issues/33780: [MFTF] Investigate and fix code affected by saner string to number comparisons #33780

Contribution checklist

[ ] Pull request has a meaningful description of its purpose
[ ] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/verification tests (if applicable)
[ ] All automated tests passed successfully (all builds on Travis CI are green)
[ ] Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

bohdan-harniuk commented 3 years ago

Hello, @jilu1!

Please, proceed with the code review.

Thanks, Bohdan.

jilu1 commented 3 years ago

@bohdan-harniuk The builds are run on PHP 7, right? Let's also run on PHP 8 when the docker image is available.

jilu1 commented 3 years ago

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

bohdan-harniuk commented 3 years ago

@bohdan-harniuk The builds are run on PHP 7, right? Let's also run on PHP 8 when the docker image is available.

@jilu1 Yes, let’s do so!

Thanks, Bohdan

magento-engcom-team commented 3 years ago

@jilu1 the pull request successfully imported.

jilu1 commented 3 years ago

@bohdan-harniuk I tried to merge this PR before PHP 8 is available, but when I run on PHP 7.4, I found these 4 tests consistently fail for EE and B2B builds. The failure is not present when running with MFTF develop branch. Can you please double check?

bohdan-harniuk commented 3 years ago

@bohdan-harniuk I tried to merge this PR before PHP 8 is available, but when I run on PHP 7.4, I found these 4 tests consistently fail for EE and B2B builds. The failure is not present when running with MFTF develop branch. Can you please double check?

Hello, @jilu1!

You just need to rerun MFTF tests. There are few common issues with them. We see them quite often. Sorry for being late. I missed the letter about it in gmail.

Thanks, Bohdan