magento / magento2-functional-testing-framework

Magento2 Functional Testing Framework
Other
155 stars 133 forks source link

Hashicorp Vault PHP lib being instantiated with wrong params #885

Closed jonatanrdsantos closed 2 years ago

jonatanrdsantos commented 2 years ago

Preconditions

  1. PHP 7.4
  2. Standalone MFTF installation
  3. Magento 2.4.3

Steps to reproduce

  1. Setup a HashiCorp Vault on a server
  2. Add CREDENTIAL_VAULT_ADDRESS and CREDENTIAL_VAULT_SECRET_BASE_PATH to dev/.env in MFTF folder
  3. Add CREDENTIAL_VAULT_ADDRESS and CREDENTIAL_VAULT_SECRET_BASE_PATH to dev/tests/acceptance/.env in Magento 2 folder
  4. Read a vault value from a test using {{_CREDS.vendor/path}}

Expected result

![mftf](https://user-images.githubusercontent.com/3149490/154159964-ae2559f6-e64a-464d-8e60-e53e3829fecf.png) ### Actual result

error-production-mftf

m2-assistant[bot] commented 2 years ago

Hi @jonatanrdsantos. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


jonatanrdsantos commented 2 years ago

@magento I am working on this

okolesnyk commented 2 years ago

Hi @jonatanrdsantos Thank you for reporting this issue and especially huge thank you for creating Pull Request. We've created internal ticket and will process your request.

jonatanrdsantos commented 2 years ago

Hi, @okolesnyk; yes, sure, it was a pleasure to contribute with Magento.