magento / magento2-jp

Magento Community Project for providing best experience for Japanese market
Open Software License 3.0
24 stars 34 forks source link

Service for name formatting #22

Open vkublytskyi opened 6 years ago

vkublytskyi commented 6 years ago

Magento 2 now have several places where customer full name is formatted. This lead to code duplication and completes customizations that is required to apply formats specific to locales. In the scope of this issue new API service should be introduced that will return customer full name based on customer data (last name, firstname etc.)

Service should be declared as an interface and has default implementation equal to current behavior.

HirokazuNishi commented 6 years ago

These classes are calling and formatting customer's first name and last name. (Just for name format)

bravebright commented 6 years ago

These are using getFirstName/getLastName and have to use name formatter. (Added a little from Nishi's list.)

magento-backend

magento-checkout

magento-customer

magento-newrelicreporting

magento-newsletter

magento-reports

magento-review

magento-sales

magento-shipping

magento-signifyd

magento-user

vkublytskyi commented 6 years ago

Additional places: