Fixing strict sprintf Phrases in php8 - Githubissues

magento / magento2-page-builder

Magento2 PageBuilder

Other

81 stars 63 forks source link

Fixing strict sprintf Phrases in php8 #780

Closed eduard13 closed 3 years ago

eduard13 commented 3 years ago

Description (*)

This PR aims to fix rendering the Phrases in sprintf, which gets only string param.

Story

Bug

Task

Fixed Issues (if relevant)

magento/magento2/issues/34085

Builds

Related Pull Requests

Manual testing scenarios (*)

...
...

Questions or comments

Checklist

[ ] Pull request has a meaningful description of its purpose
[ ] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
[ ] All automated tests passed successfully (all builds are green)

magento-automated-testing[bot] commented 3 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing[bot] commented 3 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing[bot] commented 3 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing[bot] commented 3 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing[bot] commented 3 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.