fix #537 remove layout definition

unailopez16 commented 3 years ago

Description (*)

This PR removes the layout definition from Magento\PageBuilder module in category view pages, since it's already defined in Magento\Catalog module, and due to layouts loading order it breaks the ability to apply a custom layout type from a category edit page in backou

Bug

537

Fixed Issues (if relevant)

magento/magento2-page-builder#537: Layout shouldn't be set in a page_layout xml file.

Manual testing scenarios (*)

Install Magento\PageBuilder y a M2.4.3 fresh instance
Go to Catalog -> Categories
Edit one category
Apply a custom layout type in Design Section
Layout type is not applied to front page category

Checklist

[ ] Pull request has a meaningful description of its purpose
[ ] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
[ ] All automated tests passed successfully (all builds are green)

sidolov commented 3 years ago

@magento run all tests

magento-automated-testing[bot] commented 3 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov commented 2 years ago

@magento import pr to magento-commerce/magento2-page-builder

m2-github-services commented 2 years ago

@sidolov the Pull Request is successfully imported.

norgeindian commented 2 years ago

In general: Why is this file in the page_layout folder? In my understanding, this folder is only there to create new page layouts. All other files there are used this way, only this one is not and also not mentioned in layouts.xml. May it be, that this needs to be moved to layout folder?

paras89 commented 2 years ago

@magento run all tests

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

paras89 commented 2 years ago

@unailopez16 can you pull develop branch into your fork's branch and push so we can run tests again and get to merge this PR? thanks!

paras89 commented 2 years ago

@magento run all tests

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

paras89 commented 2 years ago

@magento run Functional Tests B2B, WebAPI Tests

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

paras89 commented 2 years ago

@magento run all tests

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

kanhaiya5590 commented 1 year ago

Raised a PR - https://github.com/magento/magento2-page-builder/pull/835

to fix the fallback mechanism of this file instead of just fixing the content part.

CC : @norgeindian - https://github.com/magento/magento2-page-builder/pull/782#issuecomment-946544966 given some addition info :)

glo24157 commented 8 months ago

@magento run all tests

magento-automated-testing[bot] commented 8 months ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel commented 8 months ago

@magento run all tests

magento-automated-testing[bot] commented 8 months ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel commented 8 months ago

Hello @unailopez16,

Thanks for the contribution!

:x: QA not Passed

We have tried to reproduce the issue in the latest 2.4-develop branch but it is not reproducible for us. We can see the 1-page layout on the category page in the store view. Please refer to the below screenshot for reference:

We have followed the below steps to reproduce the issue:

Install Magento\PageBuilder in the latest development branch i.e. 2.4-develop
Go to Catalog -> Categories
Edit one category
Apply a custom layout type in the Design Section
Layout type is applied to the front page category

It seems the issue has been fixed in the latest branch. Please try to reproduce the issue and let us know if you are able to reproduce it.

Thanks

engcom-Hotel commented 7 months ago

Hello @unailopez16,

As per this comment https://github.com/magento/magento2-page-builder/pull/782#issuecomment-1895371820, we are unable to reproduce the issue in the latest development branch i.e. 2.4-develop.

We are unable to receive a reply from you on this PR, hence we are closing this PR. Please comment here if you still continue with this PR.

Thanks

magento / magento2-page-builder