Ensure Validator Value Exists Before Use

pykettk commented 2 years ago

Description (*)

Check for non-null values during margin and padding validation. Seems to be affecting Firefox 94.0.2 during cursory testing.

Dev Tools Error

Uncaught TypeError: value is null
    <anonymous> https://www.{{project-name}}.test/static/version1637759357/adminhtml/Magento/backend/en_GB/Magento_PageBuilder/js/form/element/validator-rules-mixin.js:237
    validate https://www.{{project-name}}.test/static/version1637759357/adminhtml/Magento/backend/en_GB/Magento_Ui/js/lib/validation/validator.js:44
    validator https://www.{{project-name}}.test/static/version1637759357/adminhtml/Magento/backend/en_GB/Magento_Ui/js/lib/validation/validator.js:84
    all Underscore
    validator https://www.{{project-name}}.test/static/version1637759357/adminhtml/Magento/backend/en_GB/Magento_Ui/js/lib/validation/validator.js:82
    validate https://www.{{project-name}}.test/static/version1637759357/adminhtml/Magento/backend/en_GB/Magento_Ui/js/form/element/abstract.js:406
    setNested https://www.{{project-name}}.test/static/version1637759357/adminhtml/Magento/backend/en_GB/mage/utils/objects.js:44
validator-rules-mixin.js:237:51

Screenshot 2021-11-24 at 14 24 54

Story

N/A

Bug

N/A

Task

N/A

Fixed Issues (if relevant)

N/A

Builds

Related Pull Requests

N/A

Manual testing scenarios (*)

With null margin and/or padding values in product Page Builder content:

Log into the admin using Firefox 94.0.2
Navigate to Catalog -> Inventory -> Products
Select the Edit action from the Action column in the products grid
Observe the page for the infinite loading spinner and examine the developer console for the aforementioned error

Questions or comments

N/A

Checklist

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[x] All new or changed code is covered with unit/integration tests (if applicable)
[x] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
[ ] All automated tests passed successfully (all builds are green)

pykettk commented 2 years ago

@magento run all tests

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

pykettk commented 2 years ago

@magento run all tests

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento / magento2-page-builder