magento / magento2-page-builder

Magento2 PageBuilder
Other
82 stars 63 forks source link

Change to the new slick version 1.9.0 #800

Closed in-session closed 2 years ago

in-session commented 2 years ago

Description (*)

Story

Bug

Task

Fixed Issues (if relevant)

  1. magento/magento2-page-builder#: Issue title

Builds

Related Pull Requests

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Checklist

paras89 commented 2 years ago

@in-session can you merge develop branch into your fork branch and push so we can process this PR? Thanks!

in-session commented 2 years ago

@magento run all tests

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

in-session commented 2 years ago

@paras89 as requested even though i honestly don't support slick slider at all and it would be time to say goodbye to it. Also regarding https://github.com/magento/magento2/issues/34595. Here, restructuring to Swiper would make much more sense, but unfortunately a common problem

in-session commented 2 years ago

@magento run Unit Tests

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Januszpl commented 10 months ago

@in-session it should be reverted to 1.8.1 because https://github.com/kenwheeler/slick/issues/3477#issuecomment-511957967