magento / magento2-page-builder

Magento2 PageBuilder
Other
81 stars 63 forks source link

fix container width for description inside the catalog product view #802

Closed PierW closed 1 month ago

PierW commented 2 years ago

Description (*)

When I insert the description of the product I have this problem:

Schermata 2022-02-19 alle 20 35 38

It's not aligned

FIX:

Schermata 2022-02-19 alle 20 39 30 Schermata 2022-02-19 alle 20 40 58 Schermata 2022-02-19 alle 20 37 09

The text should be aligned

Story

Bug

Task

Fixed Issues (if relevant)

  1. magento/magento2-page-builder#: Issue title

Builds

Related Pull Requests

Manual testing scenarios (*)

  1. Magento 2.4.3-p1
  2. Module Page Builder Enabled (Default)
  3. Design Page - Template Product full width (Default with page builder enabled)
  4. Enter to the backoffice
  5. Create a Product and insert a description with page builder inside a row and 1 column
  6. Save

Questions or comments

Checklist

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

paras89 commented 2 years ago

@magento run all tests

magento-automated-testing[bot] commented 2 years ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Hotel commented 10 months ago

@magento run all tests

magento-automated-testing[bot] commented 10 months ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel commented 10 months ago

@magento run Static Tests, Unit Tests, WebAPI Tests

magento-automated-testing[bot] commented 10 months ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel commented 8 months ago

@magento run all tests

engcom-Bravo commented 8 months ago

@magento give me 2.4-develop test instance

magento-deployment-service[bot] commented 8 months ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 8 months ago

Hi @engcom-Bravo, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

engcom-Bravo commented 8 months ago

@magento give me test instance

magento-deployment-service[bot] commented 8 months ago

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service[bot] commented 8 months ago

Hi @engcom-Bravo, here is your Magento Instance: https://448bc05276c29e181ed3a7033f20317d.instances-prod.magento-community.engineering Admin access: https://448bc05276c29e181ed3a7033f20317d.instances-prod.magento-community.engineering/admin_0b90 Login: 2180a752 Password: a6342b2bd182

engcom-Bravo commented 8 months ago

@magento run all tests

engcom-Bravo commented 8 months ago

Hi @PierW,

Thanks for the collaboration & contribution!

:heavy_check_mark: QA Passed

Preconditions:

Manual testing scenario:

Before: :heavy_multiplication_x: 

Screenshot from 2024-02-29 13-19-23

After: :heavy_check_mark:  

Screenshot from 2024-02-29 13-48-27

Thanks.

engcom-Hotel commented 8 months ago

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Performance Acceptance Tests, Static Tests, Unit Tests

engcom-November commented 6 months ago

@magento run all tests

engcom-November commented 6 months ago

@magento run Functional Tests CE, Integration Tests, Static Tests, WebAPI Tests

engcom-November commented 6 months ago

@magento run Static Tests

engcom-November commented 6 months ago

@magento run all tests

engcom-November commented 6 months ago

@magento run Functional Tests EE, Integration Tests, WebAPI Tests

engcom-November commented 6 months ago

@magento run WebAPI Tests

engcom-November commented 6 months ago

The WebAPI failures on consecutive runs are different, and are flaky.

1st Run

image

2nd Run

image

Hence moving this pr for further processing.

engcom-Hotel commented 6 months ago

@magento run WebAPI Tests

TuVanDev commented 3 months ago

@engcom-Hotel do you think it's better to use shorthand in this case? If so, could you make the following changes? Current code:

padding-left: 15px;
padding-right: 15px;

Proposed change:

padding: 0 15px;
engcom-Hotel commented 2 months ago

Sure @TuVanDev, Please make the change. We will then proceed with this PR.

Till then moving PR to Changes Requested

Thanks

engcom-Hotel commented 2 months ago

@magento run all tests

TuVanDev commented 2 months ago

I don't have permission to make the changes. Thanks to @engcom-Hotel for the changes.

engcom-Bravo commented 1 month ago

Hi @PierW,

Thanks for your Contribution!!.

We have verified the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.

Nadia-Elements-Shell-09-26-2024_11_42_AM

Screenshot 2024-09-26 at 11 41 46

Could you please let us know if we are missing anything here.

Thanks.

engcom-Bravo commented 1 month ago

Hi @PierW,

Thank you for your contribution!

As mentioned here https://github.com/magento/magento2-page-builder/pull/802#issuecomment-2376078694, please have a look and let us know if we are missing anything.

Till then closing this PR. Please feel free to reopen it as you want to update further.

Thank you!