Open nurullah opened 1 year ago
@magento run all tests
@magento run Functional Tests B2B
@magento run all tests
@magento run Functional Tests B2B, Integration Tests, Performance Acceptance Tests, Static Tests, Unit Tests
@magento run Functional Tests B2B
:heavy_check_mark: QA Passed
Preconditions:
Implement Slick slider with Magento and enable PageBuilder
Manual testing scenario:
Actual Result: :heavy_check_mark: The slider should accept and show the allowed number of images in the slider.
After: :heavy_check_mark:
According to changes in this PR, this will accept only integer values not decimal values.
Before: :heavy_multiplication_x: The slick slider unofficially enables decimal points in the slidesToShow attribute. When we define the 5.2 to the slidesToShow attribute, the slick slider will show 5 items and 20 percent of 6 items. But we need to use undecimal numbers in the slidesToScroll parameter. Otherwise, the slider will miscalculate. This pull request aims to solve this problem.
The Failed B2B test is flaky, past 2 consecutive runs, the build failures are different:
Hence moving to merge in progress
.
Thanks
Description (*)
Slick slider unofficially enables the use of decimal point in the slidesToShow attribute. When we define the 5.2 to the slidesToShow attribute, slick slider will show the 5 items and the 20 percent of 6 item. But we need to use undecimal number in the slidesToScroll parameter. Otherwise, the slider will miscalculate. This pull request aims to solve this problem.
Manual testing scenarios (*)
Checklist