Community - Width & Height attribute - Pagebuilder image #767

aj-prajapati commented 1 year ago

Width and Height attribute added for Pagebuilder image element

https://github.com/magento/magento2-page-builder/issues/767

Description (*)

Story

Bug

Task

Fixed Issues (if relevant)

magento/magento2-page-builder#: Issue title

Builds

Related Pull Requests

https://github.com/magento-commerce/magento2-infrastructure/pull/1880

Manual testing scenarios (*)

...
...

Questions or comments

Checklist

[ ] Pull request has a meaningful description of its purpose
[ ] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
[ ] All automated tests passed successfully (all builds are green)

Resolved issues:

[x] resolves magento/magento2-page-builder#867: Width & Height attribute - Pagebuilder image #767

larsmbm commented 11 months ago

Hello @aj-prajapati

Thanks for making this code. We do use it. Although we did add code for loading attribute as wel. We think it's a good to at it to you merge request.

This is the code we made:

pagebuilder_image_form.xml `

text Image Attribute Loading image_attribute_loading Place the value lazy on images that are below the fold on desktop for better page speed performance.

        <formElements>
            <select>
                <settings>
                    <options>
                        <option name="eager" xsi:type="array">
                            <item name="value" xsi:type="string">eager</item>
                            <item name="label" xsi:type="string">eager</item>
                        </option>
                        <option name="lazy" xsi:type="array">
                            <item name="value" xsi:type="string">lazy</item>
                            <item name="label" xsi:type="string">lazy</item>
                        </option>
                    </options>
                    <caption translate="true">Select the correct loading method for the image.</caption>
                </settings>
            </select>
        </formElements>
    </field>`

`

text Mobile Image Attribute Loading mobile_image_attribute_loading Place the value lazy on images that are below the fold on mobile for better page speed performance.

        <formElements>
            <select>
                <settings>
                    <options>
                        <option name="eager" xsi:type="array">
                            <item name="value" xsi:type="string">eager</item>
                            <item name="label" xsi:type="string">eager</item>
                        </option>
                        <option name="lazy" xsi:type="array">
                            <item name="value" xsi:type="string">lazy</item>
                            <item name="label" xsi:type="string">lazy</item>
                        </option>
                    </options>
                    <caption translate="true">Select the correct loading method for the image.</caption>
                </settings>
            </select>
        </formElements>
    </field>`

image.xml <attribute name="image_attribute_loading" source="loading"/> <attribute name="mobile_image_attribute_loading" source="loading"/>

ImageData.xml `

Loading general image_attribute_loading eager ` ` Loading general mobile_image_attribute_loading eager `

engcom-Hotel commented 8 months ago

@magento run all tests

magento-automated-testing[bot] commented 8 months ago

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel commented 7 months ago

@magento run all tests

engcom-Hotel commented 6 months ago

We are picking this PR for further development

engcom-Hotel commented 6 months ago

@magento create issue

larsmbm commented 6 months ago

Hello @engcom-Hotel,

Great that this issue is picked up for further development :) I do question will the lazy loading attribute option be added as wel? Like my comment suggest in this ticket earlier.

Thank you in advance.

engcom-Hotel commented 6 months ago

@magento run Static Tests

engcom-Hotel commented 6 months ago

@magento run Static Tests

engcom-Hotel commented 6 months ago

@magento run Static Tests

engcom-Hotel commented 6 months ago

@magento run Static Tests

engcom-Hotel commented 6 months ago

@magento run Static Tests

engcom-Hotel commented 6 months ago

@magento run Static Tests