search

magento / magento2-pwa

Other
15 stars 13 forks source link

Remove nonsense #3

Closed PascalBrouwers closed 1 year ago

PascalBrouwers commented 2 years ago

Remove nonsense about git setting to "avoid committing files by mistake"

PascalBrouwers commented 2 years ago

If you don't know what you are doing, don't put it in the readme as a suggestion.

michaelyu0123 commented 2 years ago

Hello @PascalBrouwers, the reason for the inclusion of that suggestion is mainly for those that are concurrently working on development for both this extension as well as the root project in a local environment as composer.json/.lock will get updated by step 4 which sets the local directory as the source for the extension.

By applying this suggestion, it prevents accidentally committing the change to pointing at local folder structure in the composer files up to the root projects repository.

Please let me know if the current phrasing was unclear or if there are other concerns with this and we'll do our best to address it. Thank you.

PascalBrouwers commented 2 years ago

So, you are saying people who develop this extension also have no idea what they are doing? Ps. you can also use composer require with --prefer-source This allows you do be able to develop your extension with composer instead of doing these steps.

supernova-at commented 2 years ago

you are saying people who develop this extension also have no idea what they are doing?

Hey @PascalBrouwers , comments like this are unnecessary and against the contributor code of conduct. If you have a better idea (such as using --prefer-source), please modify your PR to include that in the setup steps instead.

PascalBrouwers commented 2 years ago

Selectively quoting to make my sentence sound different is not appreciated. I think that is against the code of conduct.