search

magento / magento2-upward-connector

Magento module for routing front-end requests to UPWARD-PHP
Open Software License 3.0
24 stars 27 forks source link

Frontname Whitelist #19

Closed tjwiebell closed 4 years ago

tjwiebell commented 4 years ago

Description

Basing our work off of Experius's PR #12, cherry-pick the frontname whitelist functionality to allow certain routes to pass directly to Magento frontend.

Closes PWA-101

Steps to Validate

1) Install module on Magento 2.3.3 (preferably with some sample data) 2) Build Venia Concept with this Magento backend 3) Login to admin and go to Stores > Configuration > General > Web 4) Set UPWARD Config File to upward.yml in /dist, and add contact to Frontname Whitelist 5) Navigate to storefront and verify Venia loads 6) Navigate to a Category and Product, verify those routes work as expected 7) Navigate to /contact and verify the contact page is loaded and themed to Luma

zetlen commented 4 years ago

Thank you for this. Pending a test plan and docs, it's got my approval.

dpatil-magento commented 4 years ago

QA pass. Verified on cloud starter with PWA 4.0.0 and develop branch.