magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.31k forks source link

Free shipping code is not working for UPS for magento 2 #10704

Closed impunkj closed 4 years ago

impunkj commented 7 years ago

Preconditions

  1. Create a coupon code for free shipment.
  2. Apply to coupon code on cart page or checkout both page.
  3. Coupon applied successfully.
  4. 2.1.7 Magento

Steps to reproduce

  1. Generate a coupon code from Cart price rule for free shipping.
  2. Shipping method is UPS
  3. Applied coupon to any cart or checkout flow.

Expected result

  1. Shipping amount should be zero.
  2. Applied discount is equal to shipping amount.

Actual result

  1. [Screenshot, logs] The coupon code is applied but the amount remains same.

After applying shipping price not changed. in same case price is changing for other shipping method. Other shipping method is working fine Except UPS

impunkj commented 7 years ago

Any update on this ?

magento-engcom-team commented 7 years ago

@impunkj, thank you for your report. Please use the issue reporting guidelines to report an issue. Please, add the following information: -Preconditions: Magento version, Is Sample Data installed

impunkj commented 7 years ago

Hello , Thanks For reply. I already mention all the step but forget to mention version. It is 2.1.7 Magento

mbrzuzy commented 7 years ago

Also running into this issue. Free shipping method does not seem to be working for UPS through cart rules or through shipping configuration.

JosephMaxwell commented 6 years ago

squashtoberfest

pmoreno1980 commented 6 years ago

any update on this?

tkacheva commented 5 years ago

Issue fixed in 2.2.6

nadeefit6 commented 5 years ago

Issue is still reproducing in 2.2.7.

rafaelcalero commented 5 years ago

Issue is still reproducing in 2.2.7.

+1

nadeefit6 commented 5 years ago

Any update on a fix?

m2-assistant[bot] commented 4 years ago

Hi @engcom-Delta. Thank you for working on this issue. Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:


engcom-Delta commented 4 years ago

@nadeefit6 @rafaelcalero Unfortunately, I am not able to reproduce issue on 2.4-develop Steps to reproduce:

Actual result: :heavy_check_mark: Free shipping is applied for configured UPS method image

Could you take a look if it is correct steps to reproduce issue?

m2-assistant[bot] commented 4 years ago

Hi @Den4ik. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

Den4ik commented 4 years ago

@nadeefit6 @rafaelcalero Same results that provided by @engcom-Delta on 2.4-develop branch Before coupon apply in cart: image After coupon apply in cart: image Before coupon apply at checkout: image After coupon apply at checkout: image

Could you please provide information about shipping method and cart price rule configuration? Please verify that you selected free method config for UPS, because zero price applying just to configured free method... https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Shipping/Model/Carrier/AbstractCarrier.php#L423-L426

engcom-Delta commented 4 years ago

@nadeefit6 @rafaelcalero we are closing this issue due to inactivity. If you'd like to update the issue, please reopen it.