magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.55k stars 9.32k forks source link

Zip code Netherlands should allow zipcode without space #11898

Closed sschurink closed 7 years ago

sschurink commented 7 years ago

Issue

Zip code validation warning on adresses from Netherlands. Current validation is 1234 AA This should also allow zipcode without space 1234AA

Preconditions

On all 2.* versions including development branch.

Steps to reproduce

go to cart or checkout, select Netherlands and insert postal code 1234AA

Expected result

No warning

Actual result

Zipcode gives warning

Solution (completely written out, just copy and paste!)

Replace zip countrycode NL with:

 <zip countryCode="NL">
      <codes>
        <code id="pattern_1" active="true" example="1234 AB/1234AB">^[0-9]{4}\s?[a-zA-Z]{2}$</code>
      </codes>
    </zip> 

in /app/code/Magento/Directory/etc/zip_codes.xml

magento-engcom-team commented 7 years ago

@sschurink, thank you for your report. We've created internal ticket(s) MAGETWO-83058 to track progress on the issue.

osrecio commented 7 years ago

Working on it

ishakhsuvarov commented 7 years ago

Hi @sschurink According to this information from the post.nl website it is recommended to separate postal code digits and letters with a space. Do you have any additional information on this? Thanks

sschurink commented 7 years ago

Hai Ievgen,

That is indeed the official way to write it however due to evolving internet forms it is now also an accepted way to add no space between them. So unofficially both formats are widely accepted in the Netherlands as correct formats. And we would like to provide that service also without giving a warning box for a correct postal code (in the eyes of almost all Dutch citizens).

Thanks for checking this though!

Van: Ievgen Shakhsuvarov [mailto:notifications@github.com] Verzonden: vrijdag 3 november 2017 10:56 Aan: magento/magento2 magento2@noreply.github.com CC: Sandra Schurink sschurink@999games.nl; Mention mention@noreply.github.com Onderwerp: Re: [magento/magento2] Zip code Netherlands should allow zipcode without space (#11898)

Hi @sschurinkhttps://github.com/sschurink According to this information from the post.nl websitehttps://www.postnl.nl/en/mail-and-parcels/parcels/addressing-tips/ it is recommended to separate postal code digits and letters with a space. Do you have any additional information on this? Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/magento/magento2/issues/11898#issuecomment-341660404, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AcQjTB-WU75IvZIVv91UzS0LVEL59yqEks5syuM8gaJpZM4QMmFb.

ishakhsuvarov commented 7 years ago

@sschurink Thank you for the update.

magento-team commented 7 years ago

Internal ticket to track issue progress: MAGETWO-83195

magento-team commented 7 years ago

Internal ticket to track issue progress: MAGETWO-83194

okorshenko commented 7 years ago

The issue has been fixed in 2.2-develop branch and will be available with 2.2.2 release

magento-team commented 7 years ago

Internal ticket to track issue progress: MAGETWO-83196