search

magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.3k forks source link

Substitution payment method - Incorrect message #12209

Closed ihor-sviziev closed 6 years ago

ihor-sviziev commented 6 years ago

Preconditions

  1. Magento 2.1.9 (same should be in 2.2-develop and 2.3-develop)
  2. DB migrated from M1, payment method wasn't migrated, so it's not available

Steps to reproduce

  1. Go to Admin panel and look at existing order
  2. View "Payment & Shipping Method" section

Expected result

We should have message " is not available. You still can process offline actions." OR we should have message "Payment method is not available. You still can process offline actions.

Actual result

We have message "is not available. You still can process offline actions." image

Tech note

https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Payment/view/adminhtml/templates/info/substitution.phtml#L13

  1. payment method title isn't printed
  2. There is no check if title is not empty
magento-engcom-team commented 6 years ago

@ihor-sviziev, thank you for your report. We've created internal ticket(s) MAGETWO-83822 to track progress on the issue.

magento-team commented 6 years ago

Hi @ihor-sviziev. Thank you for your report. The issue has been fixed in magento/magento2#12731 by @zamoroka in 2.2-develop branch Related commit(s):

The fix will be available with the upcoming patch release.

okorshenko commented 6 years ago

Hi @ihor-sviziev. Thank you for your report. The issue has been fixed in magento-engcom/magento2ce#1325 by @magento-engcom-team in 2.3-develop branch Related commit(s):

The fix will be available with the upcoming 2.3.0 release.