magento / magento2

Prior to making any Submission(s), you must sign an Adobe Contributor License Agreement, available here at: https://opensource.adobe.com/cla.html. All Submissions you make to Adobe Inc. and its affiliates, assigns and subsidiaries (collectively “Adobe”) are subject to the terms of the Adobe Contributor License Agreement.
http://www.magento.com
Open Software License 3.0
11.5k stars 9.31k forks source link

Creditmemo total is negative on a 100% discounted order #12218

Closed AntonEvers closed 4 years ago

AntonEvers commented 6 years ago

This scenario can occur when reward points are used as a discount instead of a payment method. (custom code required, but not for reproducing the issue).

Preconditions

  1. 2.2-develop

Steps to reproduce

  1. Create a discount rule that gives 100% discount on all order items
  2. Refund the order, don't refund the shipping costs

Expected result

  1. The credit memo grand total total and row total should be 0

Actual result

  1. The credit memo grand total and row total is negative discount tax compensation amount

wrong: screen shot 2017-11-13 at 4 25 28 pm

right: screen shot 2017-11-13 at 4 24 47 pm

magento-engcom-team commented 6 years ago

@ajpevers, thank you for your report. We were not able to reproduce this issue by following the steps you provided. If you'd like to update it, please reopen the issue. We tested the issue on 2.3.0-dev, 2.1.10, 2.2.1

ebaschiera commented 6 years ago

I got the same issue with a 94% discount on a whole cart. I am refunding also shipping cost. Commmit https://github.com/ajpevers/magento2/commit/847d412f8f9e2abeba97ac3999f6a1fbdf3ae9f2 fixed my issue. Thanks!

ebaschiera commented 6 years ago

Sorry, I forgot to mention that I am on Magento EE 2.1.10.

ihor-sviziev commented 6 years ago

Hi @engcom-backlog-pb, could you re-check this issue? we have request that this issue still reproducting in 2.2. https://github.com/magento/magento2/pull/12219#issuecomment-393842726

engcom-backlog-nickolas commented 6 years ago

@AntonEvers, @ihor-sviziev I'm not able to reproduce this issue on current 2.2-develop peek 2018-08-10 14-32

@AntonEvers, could you please correct my steps, or add more details?

ihor-sviziev commented 6 years ago

Maybe @elvinristi could also check if steps are correct?

elvinristi commented 6 years ago

@ihor-sviziev will try to find time to produce steps this week but my conditions were :

at that time was this replicated on M2.2.2 Commerce.

engcom-backlog-nickolas commented 6 years ago

@elvinristi, @ihor-sviziev I've tried to reproduce with tax 5% and coupon with discount amount 99.9%. Still cannot get actual result from steps to reproduce. peek 2018-08-15 14-23

elvinristi commented 6 years ago

@ihor-sviziev , in short - couldn't replicate with latest 2.2.6-dev CE.

Preconditions:

FRONTEND, as a guest

ADMIN

Issue couldn't be replicated with these settings. Can't currently recall more details to conditions what could bring in this issue. Maybe this falls back to the payment method logic what's used.

I guess both these issues (#12218 and #12219 ) can be closed.

dthivanka commented 4 years ago

I was able to reproduce this issue in a Magento 2.3.4 instance with sample data. You need to have following tax calculation settings to reproduce this. Screenshot from 2020-02-18 12-43-48

follow @elvinristi steps to reproduce.

https://github.com/magento/magento2/pull/12219/commits fix the issue

ihor-sviziev commented 4 years ago

@magento give me 2.4-develop instance @dthivanka could you try to reproduce it on test instance?

magento-engcom-team commented 4 years ago

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team commented 4 years ago

Hi @ihor-sviziev, here is your Magento instance. Admin access: https://i-12218-2-4-develop.instances.magento-community.engineering/admin_8101 Login: 40a74aa0 Password: 7ddd5db5252d Instance will be terminated in up to 3 hours.

dthivanka commented 4 years ago

@ihor-sviziev sure @magento-engcom-team can I get a instance with sample data ?

ihor-sviziev commented 4 years ago

@dthivanka it's not supported, but you could generate small performance profile (test products, categories, etc) here: https://i-12218-2-4-develop.instances.magento-community.engineering/pub/testing/

dthivanka commented 4 years ago

@ihor-sviziev Can't replicate on magento 2.4-develop branch instance. May be it's fixed now on develop branch

ihor-sviziev commented 4 years ago

@dthivanka thank you for confirmation! In this case I'm closing this issue